Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modularized property #9927

Merged
merged 41 commits into from
Dec 18, 2024
Merged

Add modularized property #9927

merged 41 commits into from
Dec 18, 2024

Conversation

bilyana-gospodinova
Copy link
Contributor

Description:
The integration of reusable services will span through multiple releases and will be delivered in chunks. That's why we need a feature flag to disable the new code before it's fully implemented and properly tested.

Fixes #9261

@bilyana-gospodinova
Add MirrorNodeState init with subcomponents
e57a0bc 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Add more tests and fix code smells
f67a110 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Fix code smell and add tests for MetricsImpl to increase coverage
02f7e94 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Remove the public modifier of the test class
5dd1280 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Add file id and init bytecode in context
c29f2a9 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Merge from main
fef1ef0 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Merge from base branch
916b3da 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova bilyana-gospodinova added enhancement Type: New feature web3 Area: Web3 API labels Dec 10, 2024
@bilyana-gospodinova bilyana-gospodinova self-assigned this Dec 10, 2024
@bilyana-gospodinova
Add modularized property
79a481b 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova bilyana-gospodinova force-pushed the 09261-modularized-services-flag branch from 0380aef to 79a481b Compare December 10, 2024 09:08
@bilyana-gospodinova bilyana-gospodinova marked this pull request as ready for review December 10, 2024 09:27
@bilyana-gospodinova bilyana-gospodinova requested a review from a team as a code owner December 10, 2024 09:28
@bilyana-gospodinova
Fix compile issue
1e7a0f6 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Fix PR comments
604a7e6 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Merge branch '09791-init-mirror-node-state-and-subcomponents' into 09…
fc2ed49 
…798-enhance-FileReadableKVState-to-fetch-contract-from-ContractCallContext
@bilyana-gospodinova
Combine the 2 context parameters into 1
398c23a 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Merge remote-tracking branch 'origin' into 09791-init-mirror-node-sta…
9ed767b 
…te-and-subcomponents
@bilyana-gospodinova
Merge from base branch
056f847 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Revert timestamp change
545356e 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Revert a bit more unneded changes
ea96aec 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Merge from base branch
7e1a7d1 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Merge from base branch
1007ff8 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Cleanup
c92261c 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Merge branch '09798-enhance-FileReadableKVState-to-fetch-contract-fro…
829c7dc 
…m-ContractCallContext' into 09261-modularized-services-flag
@bilyana-gospodinova
Fix some old failing tests
44fef3f 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@steven-sheehy steven-sheehy added this to the 0.121.0 milestone Dec 12, 2024
Base automatically changed from 09798-enhance-FileReadableKVState-to-fetch-contract-from-ContractCallContext to main December 12, 2024 15:42
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.31973% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.32%. Comparing base (fcd2790) to head (d187a13).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...rror/web3/service/TransactionExecutionService.java 99.13% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #9927      +/-   ##
============================================
+ Coverage     92.21%   92.32%   +0.11%     
+ Complexity     7840     7748      -92     
============================================
  Files           954      938      -16     
  Lines         32791    32636     -155     
  Branches       4141     4125      -16     
============================================
- Hits          30238    30132     -106     
+ Misses         1581     1533      -48     
+ Partials        972      971       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

steven-sheehy
steven-sheehy requested changes Dec 12, 2024
View reviewed changes
...mirror-web3/src/main/java/com/hedera/mirror/web3/evm/properties/MirrorNodeEvmProperties.java Show resolved Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/service/ContractCallService.java Outdated Show resolved Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/service/ContractCallService.java Outdated Show resolved Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/service/ContractCallService.java Outdated Show resolved Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/service/ContractCallService.java Outdated Show resolved Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/service/ContractCallService.java Outdated Show resolved Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/service/ContractCallService.java Outdated Show resolved Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/service/ContractCallService.java Outdated Show resolved Hide resolved
@bilyana-gospodinova
Reuse properties between calls
b55c594 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@kselveliev kselveliev mentioned this pull request Dec 16, 2024
Merged
2 tasks
kselveliev and others added 3 commits December 16, 2024 18:34
@kselveliev
feat: Wrap modularized code in transactionExecutionService (#9943)
fb69f19 
* feat: Wrap modularized code in transactionExecutionService and add opcodeTracer

Signed-off-by: Kristiyan Selveliev <[email protected]>
@bilyana-gospodinova
spotlessApply task
c35f3df 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Try to fix code smells
abbb0f9 
Signed-off-by: Bilyana Gospodinova <[email protected]>
steven-sheehy
steven-sheehy requested changes Dec 16, 2024
View reviewed changes
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/service/TransactionExecutionService.java Outdated Show resolved Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/state/AccountReadableKVState.java Outdated Show resolved Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/state/MirrorNodeState.java Outdated Show resolved Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/state/MirrorNodeState.java Outdated Show resolved Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/service/ContractCallService.java Outdated Show resolved Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/service/ContractCallService.java Outdated Show resolved Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/service/TransactionExecutionService.java Outdated Show resolved Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/service/TransactionExecutionService.java Outdated Show resolved Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/service/TransactionExecutionService.java Outdated Show resolved Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/service/TransactionExecutionService.java Outdated Show resolved Hide resolved
bilyana-gospodinova and others added 8 commits December 16, 2024 22:29
@bilyana-gospodinova
Fix merge issues
8f96154 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@kselveliev
test: Add codecov
fb747ae 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@bilyana-gospodinova
Fix code smell for hardcoded version
7a80d88 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Merge from main
8f5a26d 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@kselveliev
fix: Addressing review comment
5759feb 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@bilyana-gospodinova
Fix PR comments
32f1761 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Fix code smell
5b4dc20 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@bilyana-gospodinova
Fix mockito issue
ed309eb 
Signed-off-by: Bilyana Gospodinova <[email protected]>
bilyana-gospodinova and others added 3 commits December 18, 2024 11:17
@bilyana-gospodinova
Reduce the number of set accounts
c3a70c4 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@kselveliev
fix: Addressing review comment
02f14f9 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@bilyana-gospodinova
Increase coverage
d187a13 
Signed-off-by: Bilyana Gospodinova <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

steven-sheehy
steven-sheehy approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 991f378 into main Dec 18, 2024
32 checks passed
@steven-sheehy steven-sheehy deleted the 09261-modularized-services-flag branch December 18, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kselveliev kselveliev kselveliev left review comments

@steven-sheehy steven-sheehy steven-sheehy approved these changes

Assignees

@bilyana-gospodinova bilyana-gospodinova

Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
None yet
Milestone
0.121.0
Development

Successfully merging this pull request may close these issues.

Add feature flag for reusable services integration
3 participants
@bilyana-gospodinova @steven-sheehy @kselveliev