Fix code smells #9910
Merged
Fix code smells #9910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9910 +/- ##
============================================
- Coverage 92.25% 92.25% -0.01%
Complexity 7821 7821
============================================
Files 953 953
Lines 32731 32730 -1
Branches 4146 4146
============================================
- Hits 30196 30195 -1
Misses 1559 1559
Partials 976 976 ☔ View full report in Codecov by Sentry. |
Signed-off-by: sdimitrov9 <[email protected]>
sdimitrov9
force-pushed
the
9010-fix-code-smells
branch
from
8481a02 to
51fdb80
Compare
steven-sheehy
requested changes
Dec 9, 2024
...-mirror-grpc/src/test/java/com/hedera/mirror/grpc/repository/TopicMessageRepositoryTest.java
Show resolved
Hide resolved
…ew other sonar issues Signed-off-by: sdimitrov9 <[email protected]>
|
Looks like your change violates spotless check |
sdimitrov9
force-pushed
the
9010-fix-code-smells
branch
from
8ab4217 to
83ec3b6
Compare
Signed-off-by: sdimitrov9 <[email protected]>
sdimitrov9
force-pushed
the
9010-fix-code-smells
branch
from
83ec3b6 to
4e064e2
Compare
|
Fixed + additional code smells fixes added to the latest commit |
steven-sheehy
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
200+ sonar issues are expected to be fixed with this PR
Related issue(s):
Partially fixes 9010
Checklist