Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST Integration tests improvements 1 #590

Merged
merged 5 commits into from
Mar 11, 2020
Merged

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Mar 11, 2020

Detailed description:
REST API tests have been hard to decipher, modify and are sometimes not consistent.
These changes provide some scaffolding and changes to improve the integration tests on the REST side

  • Added integration_db_ops.js file to handle db logic and docker management
  • Removed sqlconnection references from integration.test.js
  • Implemented beforeeach logic to make tests more atomic. Updated data json file appropriately

Which issue(s) this PR fixes:
Partially addresses #412 with inspiration from #529

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@Nana-EC Nana-EC added enhancement Type: New feature P2 test Test infrastructure, automated tests required, etc rest Area: REST API labels Mar 11, 2020
@Nana-EC Nana-EC added this to the Mirror 0.7.0 milestone Mar 11, 2020
@Nana-EC Nana-EC self-assigned this Mar 11, 2020
Copy link
Contributor

@apeksharma apeksharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe you want to iteratively make these tests better by sending in small patches and have some direction in mind (?). I wouldn't waste time on review iterations to make individual PR marginally better.
I don't mind small errors in individual PRs if we can get to 'good tests' faster.
Keep the good stuff coming.
skimmed, changes are only in test files, so approved.
edit: once the checks pass, ping me, i'll re-apply the approval.

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #590 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #590   +/-   ##
=========================================
  Coverage     64.49%   64.49%           
  Complexity      171      171           
=========================================
  Files           101      101           
  Lines          3157     3157           
  Branches        363      363           
=========================================
  Hits           2036     2036           
  Misses          971      971           
  Partials        150      150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92c525...0667d0b. Read the comment docs.

@Nana-EC Nana-EC merged commit 6fee659 into master Mar 11, 2020
@Nana-EC Nana-EC deleted the rest_int_test_improvement branch March 11, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature P2 rest Area: REST API test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants