-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST Integration tests improvements 1 #590
Conversation
Signed-off-by: Nana-EC <[email protected]>
Signed-off-by: Nana-EC <[email protected]>
…json appropriately Signed-off-by: Nana-EC <[email protected]>
Signed-off-by: Nana-EC <[email protected]>
Signed-off-by: Nana-EC <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe you want to iteratively make these tests better by sending in small patches and have some direction in mind (?). I wouldn't waste time on review iterations to make individual PR marginally better.
I don't mind small errors in individual PRs if we can get to 'good tests' faster.
Keep the good stuff coming.
skimmed, changes are only in test files, so approved.
edit: once the checks pass, ping me, i'll re-apply the approval.
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
=========================================
Coverage 64.49% 64.49%
Complexity 171 171
=========================================
Files 101 101
Lines 3157 3157
Branches 363 363
=========================================
Hits 2036 2036
Misses 971 971
Partials 150 150 Continue to review full report at Codecov.
|
Detailed description:
REST API tests have been hard to decipher, modify and are sometimes not consistent.
These changes provide some scaffolding and changes to improve the integration tests on the REST side
Which issue(s) this PR fixes:
Partially addresses #412 with inspiration from #529
Special notes for your reviewer:
Checklist