Postgres Writer #3 : Move transaction and batching #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followups from previous reviews: - Add NotImplementedException to methods missing logic - share code between two insertFile*() functions Signed-off-by: Apekshit Sharma <[email protected]>
Signed-off-by: Apekshit Sharma <[email protected]>
apeksharma
commented
Mar 2, 2020
...orter/src/test/java/com/hedera/mirror/importer/parser/record/RecordFileLoggerCryptoTest.java
Show resolved
Hide resolved
Signed-off-by: Apekshit Sharma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
============================================
+ Coverage 64.34% 64.45% +0.11%
Complexity 171 171
============================================
Files 99 100 +1
Lines 3155 3151 -4
Branches 370 368 -2
============================================
+ Hits 2030 2031 +1
+ Misses 969 964 -5
Partials 156 156
Continue to review full report at Codecov.
|
|
ready for review. |
Nana-EC
approved these changes
Mar 2, 2020
...in/java/com/hedera/mirror/importer/parser/record/PostgresWritingRecordParsedItemHandler.java
Show resolved
Hide resolved
...-importer/src/main/java/com/hedera/mirror/importer/parser/record/RecordParserProperties.java
Show resolved
Hide resolved
...mporter/src/main/java/com/hedera/mirror/importer/parser/record/PostgresWriterProperties.java
Show resolved
Hide resolved
...mporter/src/main/java/com/hedera/mirror/importer/parser/record/PostgresWriterProperties.java
Show resolved
Hide resolved
...mirror-importer/src/main/java/com/hedera/mirror/importer/parser/record/RecordFileLogger.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
Move transaction and batching to
PostgresWritingRecordParserItemHandlerTest.Followups from previous reviews:
Signed-off-by: Apekshit Sharma [email protected]
Which issue(s) this PR fixes:
Partially fixes #566
Special notes for your reviewer:
Checklist