Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom alerts and dashboards #1170

Merged
merged 8 commits into from
Oct 23, 2020
Merged

Add custom alerts and dashboards #1170

merged 8 commits into from
Oct 23, 2020

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Oct 22, 2020

Detailed description:

  • Add custom PrometheusRule alerts for gRPC, Importer and REST
  • Add gRPC API dashboard
  • Add REST API dashboard
  • Add balances and events to the Importer dashboard
  • Add namespace filter to Mirror Node dashboards
  • Add hedera.mirror.parse.duration metric for balances
  • Add hedera.mirror.parse.latency metric for balances
  • Add record/balance file age single stat and graph to importer dashboard
  • Change dashboards to use the new dynamic $__rate_interval variable instead of our manually specified interval approach
  • Change tests to use Redis 5.0.9 to match our VM environments
  • Disable kubelet monitoring in GKE since it isn't possible and generates false alerts
  • Fix docker-compose not working due to lack of Redis
  • Remove non-working Swagger dashboard
  • Remove Go as code scanning language as it fails without Go code in master

Which issue(s) this PR fixes:
Fixes #660

Special notes for your reviewer:
Vast majority of the +9K/-3K changes are dashboard related changes and can be ignored.

Checklist

  • Documentation added
  • Tests updated

@steven-sheehy steven-sheehy added enhancement Type: New feature P2 process Build or test related tasks labels Oct 22, 2020
@steven-sheehy steven-sheehy added this to the Mirror 0.22.0 milestone Oct 22, 2020
@steven-sheehy steven-sheehy requested a review from a team October 22, 2020 14:51
@steven-sheehy steven-sheehy self-assigned this Oct 22, 2020
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #1170 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1170      +/-   ##
============================================
+ Coverage     87.99%   88.05%   +0.05%     
- Complexity      234      235       +1     
============================================
  Files           220      220              
  Lines          5424     5440      +16     
  Branches        602      603       +1     
============================================
+ Hits           4773     4790      +17     
+ Misses          456      455       -1     
  Partials        195      195              
Impacted Files Coverage Δ Complexity Δ
...rter/parser/balance/AccountBalancesFileLoader.java 93.57% <100.00%> (+0.82%) 0.00 <0.00> (ø)
...r/grpc/retriever/PollingTopicMessageRetriever.java 96.15% <0.00%> (-1.93%) 10.00% <0.00%> (ø%)
...rror/grpc/listener/SharedPollingTopicListener.java 98.03% <0.00%> (+3.92%) 6.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e100944...95ba26a. Read the comment docs.

@steven-sheehy steven-sheehy requested a review from beeradb October 22, 2020 17:34
@steven-sheehy steven-sheehy requested a review from Nana-EC October 23, 2020 21:27
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit e94cc8f into master Oct 23, 2020
@steven-sheehy steven-sheehy deleted the custom-alerts branch October 23, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature P2 process Build or test related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes: Application Dashboards
2 participants