Modularized fix nft tests in ModificationPrecompile #10192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onTest Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10192 +/- ##
============================================
- Coverage 92.22% 92.21% -0.01%
Complexity 7929 7929
============================================
Files 966 967 +1
Lines 33125 33139 +14
Branches 4173 4175 +2
============================================
+ Hits 30548 30558 +10
- Misses 1596 1600 +4
Partials 981 981 ☔ View full report in Codecov by Sentry. |
kselveliev
added
web3
kselveliev
requested review from
bilyana-gospodinova,
steven-sheehy,
sdimitrov9,
IvanKavaldzhiev and
nickeynikolovv
Signed-off-by: Kristiyan Selveliev <[email protected]>
kselveliev
commented
Jan 21, 2025
kselveliev
commented
Jan 21, 2025
...mirror-web3/src/main/java/com/hedera/mirror/web3/state/TokenRelationshipReadableKVState.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
steven-sheehy
previously approved these changes
Jan 21, 2025
|
spotless warning |
Signed-off-by: Kristiyan Selveliev <[email protected]>
|
steven-sheehy
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes wipeNFT, create2ContractAndTransferFromIt, cryptoTransferNft, updateTokenInfo tests
Including a bug fix in TokenRelationshipReadableKVState
This PR modifies ... in order to support ...
TokenRelationshipReadableKVState - bug fix missplaced parameters
ContractCallServicePrecompileModificationTest - fix tess setup of the 4 fixed tests
Related issue(s):
Partially handles #9984
Notes for reviewer:
Checklist