Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests in ContractCallServicePrecompileModificationTest #10116

Merged
merged 11 commits into from
Jan 15, 2025
Merged

Fix failing tests in ContractCallServicePrecompileModificationTest #10116

merged 11 commits into from
Jan 15, 2025

Conversation

sdimitrov9
Copy link
Contributor

@sdimitrov9 sdimitrov9 commented Jan 13, 2025 •
edited by steven-sheehy
Loading

Description:
Fix multiple tests within ContractCallServicePrecompileModificationTest class

Related issue(s):
Fixes #9984

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

sdimitrov9 and others added 5 commits January 9, 2025 19:03
@sdimitrov9
Fix tests
cad5fad 
Signed-off-by: sdimitrov9 <[email protected]>
@kselveliev
fix: Fix expiry info test
ab7015e 
Signed-off-by: Kristiyan Selveliev <[email protected]>
@sdimitrov9
fix wipeFungibleToken test
cc6561f 
Signed-off-by: sdimitrov9 <[email protected]>
@sdimitrov9
fix wipeNFT test
3e5ce1e 
Signed-off-by: sdimitrov9 <[email protected]>
@sdimitrov9
fix deleteToken test
370b600 
Signed-off-by: sdimitrov9 <[email protected]>
@sdimitrov9 sdimitrov9 self-assigned this Jan 13, 2025
@sdimitrov9 sdimitrov9 force-pushed the 9984-fix-faiing-tests branch from c56132d to 1cab7e2 Compare January 13, 2025 13:00
@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.20%. Comparing base (dbd5b4a) to head (6ce5493).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #10116   +/-   ##
=========================================
  Coverage     92.19%   92.20%           
  Complexity     7860     7860           
=========================================
  Files           956      956           
  Lines         32859    32859           
  Branches       4151     4151           
=========================================
+ Hits          30295    30296    +1     
  Misses         1587     1587           
+ Partials        977      976    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdimitrov9 sdimitrov9 force-pushed the 9984-fix-faiing-tests branch from 1cab7e2 to 4c8757b Compare January 13, 2025 14:05
@sdimitrov9
fix pauseToken test
6adff27 
Signed-off-by: sdimitrov9 <[email protected]>
@sdimitrov9 sdimitrov9 force-pushed the 9984-fix-faiing-tests branch from 4c8757b to 6adff27 Compare January 13, 2025 14:16
@sdimitrov9 sdimitrov9 marked this pull request as ready for review January 13, 2025 14:37
@sdimitrov9 sdimitrov9 requested a review from a team as a code owner January 13, 2025 14:37
@sdimitrov9 sdimitrov9 changed the title 9984 fix faiing tests 9984 fix failing tests in ContractCallServicePrecompileModificationTest class Jan 13, 2025
@sdimitrov9
refactor tests
1e50579 
Signed-off-by: sdimitrov9 <[email protected]>
@steven-sheehy steven-sheehy added enhancement Type: New feature test Test infrastructure, automated tests required, etc web3 Area: Web3 API labels Jan 13, 2025
@steven-sheehy steven-sheehy added this to the 0.122.0 milestone Jan 13, 2025
@steven-sheehy steven-sheehy changed the title 9984 fix failing tests in ContractCallServicePrecompileModificationTest class Fix failing tests in ContractCallServicePrecompileModificationTest Jan 13, 2025
@sdimitrov9
refactor tests
f382bea 
Signed-off-by: sdimitrov9 <[email protected]>
@sdimitrov9
resolve conflicts
5f85c56 
Signed-off-by: sdimitrov9 <[email protected]>
@sdimitrov9 sdimitrov9 force-pushed the 9984-fix-faiing-tests branch from 0c90a38 to 5f85c56 Compare January 14, 2025 07:48
bilyana-gospodinova
bilyana-gospodinova previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

steven-sheehy
steven-sheehy previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but looks like merge conflicts after merging some others

@sdimitrov9
resolve conflicts
6ce5493 
Signed-off-by: sdimitrov9 <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@steven-sheehy steven-sheehy merged commit 3572784 into main Jan 15, 2025
34 checks passed
@steven-sheehy steven-sheehy deleted the 9984-fix-faiing-tests branch January 15, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@bilyana-gospodinova bilyana-gospodinova bilyana-gospodinova left review comments

@xin-hedera xin-hedera Awaiting requested review from xin-hedera

@edwin-greene edwin-greene Awaiting requested review from edwin-greene

Assignees

@sdimitrov9 sdimitrov9

Labels
enhancement Type: New feature test Test infrastructure, automated tests required, etc web3 Area: Web3 API
Projects
None yet
Milestone
0.122.0
Development

Successfully merging this pull request may close these issues.

Fix ContractCallServicePrecompileModificationTest
4 participants
@sdimitrov9 @steven-sheehy @bilyana-gospodinova @kselveliev