Run estimate gas lazily in web3 tests #10093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <[email protected]>
steven-sheehy
added
enhancement
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10093 +/- ##
============================================
- Coverage 92.21% 92.20% -0.02%
+ Complexity 7858 7856 -2
============================================
Files 956 956
Lines 32938 32938
Branches 4151 4151
============================================
- Hits 30373 30369 -4
- Misses 1588 1591 +3
- Partials 977 978 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Run estimate gas lazily in web3 tests. Reduces the number of unnecessary estimate calls by 234 and the overall test time by 1 minute (from 4 to 3 min locally).
Related issue(s):
Notes for reviewer:
Checklist