Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MAX_GAS_LIMIT_EXCEEDED test failures in modularized web3 #10070

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Jan 8, 2025

Description:

  • Fix MAX_GAS_LIMIT_EXCEEDED pre-check failure in modularized web3 tests due to specifying 15M gas in request but overriding maxGasPerSec=10M in test config
  • Improve error message in tests to include the decoded data (which usually includes the HAPI response code)

Related issue(s):

Notes for reviewer:

Fixes 400+ tests:

Before

3341 tests completed, 755 failed, 6 skipped

After

3341 tests completed, 332 failed, 6 skipped

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added bug Type: Something isn't working web3 Area: Web3 API labels Jan 8, 2025
@steven-sheehy steven-sheehy added this to the 0.122.0 milestone Jan 8, 2025
@steven-sheehy steven-sheehy self-assigned this Jan 8, 2025
@steven-sheehy steven-sheehy requested a review from a team as a code owner January 8, 2025 23:59
@steven-sheehy steven-sheehy changed the title Fix MAX_GAS_LIMIT_EXCEEDED test failures in modularized web3 Fix MAX_GAS_LIMIT_EXCEEDED test failures in modularized web3 Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.30%. Comparing base (38d240b) to head (030f559).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../web3/exception/MirrorEvmTransactionException.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10070      +/-   ##
============================================
+ Coverage     92.23%   92.30%   +0.07%     
+ Complexity     7857     7754     -103     
============================================
  Files           956      938      -18     
  Lines         32933    32685     -248     
  Branches       4153     4131      -22     
============================================
- Hits          30376    30171     -205     
+ Misses         1580     1542      -38     
+ Partials        977      972       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Steven Sheehy <[email protected]>
Copy link

sonarqubecloud bot commented Jan 9, 2025

Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kselveliev kselveliev self-requested a review January 9, 2025 15:03
@steven-sheehy steven-sheehy merged commit e9f177b into main Jan 9, 2025
35 of 36 checks passed
@steven-sheehy steven-sheehy deleted the fix-max-gas-limit-exceeded branch January 9, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working web3 Area: Web3 API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants