Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single sonar exclusion property #10037

Merged

Conversation

sdimitrov9
Copy link
Contributor

Description:
Use single sonar exclusion property, because only the last one is taken into account.

Multiple sonar issues are going to be fixed as part of 9010 issue.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

sonarqubecloud bot commented Jan 3, 2025

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (9a973d7) to head (c82f679).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10037   +/-   ##
=========================================
  Coverage     92.33%   92.33%           
  Complexity     7753     7753           
=========================================
  Files           938      938           
  Lines         32663    32663           
  Branches       4131     4131           
=========================================
  Hits          30159    30159           
  Misses         1533     1533           
  Partials        971      971           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdimitrov9 sdimitrov9 marked this pull request as ready for review January 3, 2025 15:55
@sdimitrov9 sdimitrov9 requested a review from a team as a code owner January 3, 2025 15:55
@steven-sheehy steven-sheehy added the bug Type: Something isn't working label Jan 3, 2025
@steven-sheehy steven-sheehy added this to the 0.121.0 milestone Jan 3, 2025
@steven-sheehy steven-sheehy merged commit 8639460 into main Jan 3, 2025
35 of 36 checks passed
@steven-sheehy steven-sheehy deleted the 9010-use-single-sonar-exlusion-to-avoid-overriding branch January 3, 2025 16:34
@sdimitrov9 sdimitrov9 mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants