Return long term scheduled transaction in get transactions by id REST API (0.120) #10033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… API (#10028) - Query again with max scheduled transaction timestamp range if the result may miss such transactions - Fix passing incorrect value to getTransactionsByIdOrHashCacheControlHeader - Fix getTransactionsByIdOrHashCacheControlHeader unit tests Signed-off-by: Xin Li <[email protected]>
edwin-greene
approved these changes
Jan 2, 2025
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.120 #10033 +/- ##
================================================
Coverage 92.25% 92.25%
Complexity 7821 7821
================================================
Files 953 953
Lines 32731 32749 +18
Branches 4146 4151 +5
================================================
+ Hits 30197 30214 +17
Misses 1559 1559
- Partials 975 976 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR cherry-picks the fix to
release/0.120Related issue(s):
Fixes #10027
Notes for reviewer:
Checklist