Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Simulator helm chart #442

Merged
merged 11 commits into from
Jan 13, 2025
Merged

feat: Simulator helm chart #442

merged 11 commits into from
Jan 13, 2025

Conversation

AlfredoG87
Copy link
Contributor

Description:
Helm Chart for the BlockStream Simulator, to allow using the simulator in cloud infrastructure or any K8 Cluster.

Related issue(s):

Fixes #438

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 added Release Issues tied to release management functions Simulator Issue related to Block Stream Simulator labels Jan 2, 2025
@AlfredoG87 AlfredoG87 added this to the 0.3.0 milestone Jan 2, 2025
@AlfredoG87 AlfredoG87 self-assigned this Jan 2, 2025
@AlfredoG87 AlfredoG87 marked this pull request as ready for review January 3, 2025 16:32
@AlfredoG87 AlfredoG87 requested review from a team as code owners January 3, 2025 16:32
ata-nas
ata-nas reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, couple of questions.

.github/workflows/release-push-image.yaml Outdated Show resolved Hide resolved
charts/blockstream-simulator/.helmignore Outdated Show resolved Hide resolved
charts/blockstream-simulator/templates/NOTES.txt Outdated Show resolved Hide resolved
@ata-nas ata-nas mentioned this pull request Jan 6, 2025
Merged
2 tasks
@AlfredoG87 AlfredoG87 changed the base branch from main to publish-simulator-image January 6, 2025 14:57
@AlfredoG87 AlfredoG87 force-pushed the publish-simulator-image branch from 9650f65 to 0c99c83 Compare January 7, 2025 17:03
@AlfredoG87 AlfredoG87 force-pushed the simulator-helm-chart branch from 1301d4f to 8de0a84 Compare January 8, 2025 00:49
ata-nas
ata-nas reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, should license headers be present on all files?

@AlfredoG87
Copy link
Contributor Author

AlfredoG87 commented Jan 9, 2025 •
edited
Loading

LG, should license headers be present on all files?

In principle yes, we should.

I have added Licence header to all new and existing helm charts in this repository.

mishomihov00
mishomihov00 previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to .github/workflows/release-push-image.yaml

ata-nas
ata-nas previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from publish-simulator-image to main January 9, 2025 17:52
@AlfredoG87 AlfredoG87 dismissed stale reviews from ata-nas and mishomihov00 January 9, 2025 17:52

The base branch was changed.

@AlfredoG87 AlfredoG87 force-pushed the simulator-helm-chart branch from 3430519 to f68e5fd Compare January 9, 2025 17:58
mattp-swirldslabs
mattp-swirldslabs previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.83%. Comparing base (876ffef) to head (f68e5fd).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #442   +/-   ##
=========================================
  Coverage     96.83%   96.83%           
  Complexity      420      420           
=========================================
  Files            82       82           
  Lines          1483     1483           
  Branches         93       93           
=========================================
  Hits           1436     1436           
  Misses           34       34           
  Partials         13       13

mishomihov00
mishomihov00 previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to .github/workflows/release-push-image.yaml

@AlfredoG87 AlfredoG87 force-pushed the simulator-helm-chart branch from f68e5fd to c1369ca Compare January 10, 2025 16:28
@AlfredoG87
Remove limits due to evidence against setting it.
ee4523a 
Added default limit, but apply it only if exists.
Refactor of values using chart value instead of blockNode level specific to do as common practices

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
initial working copy of simulator helm chart, missing NOTES, complete…
1a98c68 
… README.md and further improvements

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
improvements to chart doc README.md
086d614 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
fixing default server host on values.yaml to match documentation and …
bb8e248 
…default instructions on other chart

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
fixing .with block to access the right sub-fields
0cbeada 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
adding helm chart to publish CI process
bbe2e48 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
removing extra white line at the start of values file
960d32e 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
adding install NOTES.txt
04ca592 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
adding licence header to all helm templates, and helm chart files
17cfd8b 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
style fixes from spotless
331f0d7 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
fix for helm chart CI
d8232d7 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 force-pushed the simulator-helm-chart branch from 8539234 to d8232d7 Compare January 10, 2025 19:53
mattp-swirldslabs
mattp-swirldslabs approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mishomihov00
mishomihov00 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to .github/workflows/release-push-image.yaml

ata-nas
ata-nas approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@AlfredoG87 AlfredoG87 merged commit 9a2e8f9 into main Jan 13, 2025
13 checks passed
@AlfredoG87 AlfredoG87 deleted the simulator-helm-chart branch January 13, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishomihov00 mishomihov00 mishomihov00 approved these changes

@mattp-swirldslabs mattp-swirldslabs mattp-swirldslabs approved these changes

@ata-nas ata-nas ata-nas approved these changes

@dalvizu dalvizu Awaiting requested review from dalvizu dalvizu is a code owner automatically assigned from hashgraph/platform-ci

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hashgraph/release-engineering-managers

Assignees

@AlfredoG87 AlfredoG87

Labels
Release Issues tied to release management functions Simulator Issue related to Block Stream Simulator
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Create and Publish Helm Chart for Simulator
4 participants
@AlfredoG87 @ata-nas @mattp-swirldslabs @mishomihov00