-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimize blockstream processing #358
feat: optimize blockstream processing #358
Conversation
2c8f15e
to
4a8b020
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my first pass through the changes, looks good! Just a couple of questions.
server/src/main/java/com/hedera/block/server/pbj/PbjBlockAccessServiceProxy.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/pbj/PbjBlockStreamServiceProxy.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/persistence/storage/write/NoOpBlockWriter.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
5d5773c
to
65f3d5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
============================================
+ Coverage 94.62% 97.72% +3.09%
- Complexity 316 332 +16
============================================
Files 69 69
Lines 1228 1229 +1
Branches 84 86 +2
============================================
+ Hits 1162 1201 +39
+ Misses 55 19 -36
+ Partials 11 9 -2
|
Description:
unparsed.proto
to definebytes
types at various levels from the top down to avoid marshaling all the objects*Unparsed
JProfiler
debugging ability toupdate-env.sh
anddocker-compose.yml
for troubleshootingRelated issue(s):
Fixes #353 #356
Notes for reviewer:
Checklist