Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importlib_resource new API #14

Closed
HelgeKrueger opened this issue Aug 18, 2023 · 0 comments
Closed

importlib_resource new API #14

HelgeKrueger opened this issue Aug 18, 2023 · 0 comments

Comments

@HelgeKrueger
Copy link

When running tests with python 3.11, I get the following warning:

../../../root/.cache/pypoetry/virtualenvs/bovine-herd-jY87IYlK-py3.11/lib/python3.11/site-packages/multiformats_config/multicodec.py:80
  /root/.cache/pypoetry/virtualenvs/bovine-herd-jY87IYlK-py3.11/lib/python3.11/site-packages/multiformats_config/multicodec.py:80: DeprecationWarning: open_text is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.
    with importlib_resources.open_text("multiformats_config", "multicodec-table.json", encoding="utf8") as _table_f:

My reading of https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy says that fixing this would mean going Python 3.9 only. Is there any objection to doing this?

If not, I can prepare a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant