Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using on instead of bind #327

Merged
merged 1 commit into from
Apr 26, 2016
Merged

using on instead of bind #327

merged 1 commit into from
Apr 26, 2016

Conversation

iambibhas
Copy link
Contributor

bind works too, but on is the recommended way.

Also, was missing gif on the alert.

@jace
Copy link
Member

jace commented Apr 26, 2016

Since we don't support animated GIFs, mentioning GIF support may be misleading. The rest is cool.

@jace jace merged commit 4344466 into hasgeek:master Apr 26, 2016
@iambibhas
Copy link
Contributor Author

So, let it be? or should I remove the GIF parts?

@jace
Copy link
Member

jace commented Apr 26, 2016

Remove mention of GIF for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iambibhas @jace