Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location landing page needs board-specific detail #333

Closed
jace opened this issue May 2, 2016 · 0 comments
Closed

Location landing page needs board-specific detail #333

jace opened this issue May 2, 2016 · 0 comments

Comments

@jace
Copy link
Member

jace commented May 2, 2016

Related to #304, a location landing page may need board-specific text. For example this page for Bangalore in the internships sub-board:

  1. Should have the title "Internships in Bangalore", not "Bangalore | Internships"
  2. Should have a description that serves as a landing page for that specific board
  3. Should not have a <link rel="canonical" …> pointing back to the root domain

The current Location model uses geonameid as sole primary key. This precludes more than one instance from existing. We could make it a compound primary key of geonameid and board_id, thereby requiring a board to exist for a location to be added, but perhaps this isn't a problem anymore.

@jace jace closed this as completed in 2d675b2 May 3, 2016
jace added a commit that referenced this issue May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant