Membership models #401
Merged
Membership models #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambibhas
reviewed
Apr 30, 2019
| if not set(roles.keys()).issubset(self.__role_columns__): | ||
| raise AttributeError("Unknown role") | ||
| self.revoked_at = db.func.utcnow() | ||
| self.revoked_by = actor |
There was a problem hiding this comment.
This can call the revoke function above?
There was a problem hiding this comment.
It could.
-
I'm evaluating having an additional column for the revocation reason, to indicate termination or replacement.
-
This code was originally a state manager transition, so one method couldn't call the other. I removed the state manager because it was too verbose for what the model needed.
This was referenced Jun 3, 2019
Closed
Open
vidya-ram
pushed a commit
that referenced
this pull request
Nov 23, 2021
vidya-ram
pushed a commit
that referenced
this pull request
Nov 23, 2021
Adds Organization admin and Project crew memberships, with Project participant Proposal memberships pending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design of the membership models is described here: #371 (comment)