Implement labels (resolves #313) #392

jace · 2019-04-08T08:25:10Z

Dependency hasgeek/baseframe#217

jace · 2019-04-08T09:07:51Z

The draft models here do not have colour code columns. This needs some thinking.

If the same label (say "Pending review") across projects has different colour codes, it will be confusing to the proposer. Instead, we could auto-calculate colour codes from the text, so that the same text will result in the same colour each time.
On the flip side, colours have cultural significance. Green, yellow and red are natural choices for "accepted", "pending" and "rejected". If the auto generator picks the wrong colours, the user will want to override. Users must have a choice, or the auto generator must be trained with a thesaurus.
Separately, we could pick a colour palette for the labelset and assign colours to labels (a) sequentially from the palette, or (b) auto pick based on title so that the same title will always pick the same item number in the palette.

* Add manage label page(WIP) * created views for labelsets and labels * Minor template changes

…level to labelsets

migrations/versions/e2be4ab896d3_migrate_old_labels.py

tests/conftest.py

Also removes the obsolete session_type and technical_level columns that have been converted to labels as of #392.

Implement labels (resolves #313)

Revised labelset and label models

516d262

jace requested a review from iambibhas April 8, 2019 08:25

Fix docstrings, add columns

49af3f6

jace mentioned this pull request Apr 8, 2019

Labels #313

Closed

jace and others added 9 commits April 8, 2019 14:39

Fix foreignkey

5dd3e91

added migration for labels

169cb1d

Merge branch 'labels' of github.com:hasgeek/funnel into labels

d5ffbed

added tests for assigning labels

239fa9a

added tests for radio labelsets

c1b655e

added mock usermanager for auth testing

f06ebcd

updated scope for user, team, profile and project fixture

cd4e894

logging in without dummy usermanager

87b1f62

Add manage label page(WIP) (#394)

7b40639

* Add manage label page(WIP) * created views for labelsets and labels * Minor template changes

jace mentioned this pull request Apr 11, 2019

Changesets for proposals #395

Open

Bibhas and others added 15 commits April 11, 2019 17:02

added migration for moving old sections, session types and technical …

909fa4e

…level to labelsets

some comments

3e0c426

added dynamic proposalform and handling of labels

8c74b4a

added comments

ef7ee3a

added removal of labels in non radio mode

e755ef3

Add CTA button to proposal page

3400a3e

Merge branch 'labels' of github.com:hasgeek/funnel into labels

9e51ff3

Fix styling of proposal labels

040509c

removed the inner outer form classes, added get_proposal_form

e979dee

Merge branch 'labels' of github.com:hasgeek/funnel into labels

8f8e781

added archived flag

9f9c8e9

fixed labelview loader

b99b672

added view for admins to set labels to a proposal

1ec283a

fixed new form

97ab0c8

comment

32e0db5

jace commented Apr 26, 2019

View reviewed changes

migrations/versions/e2be4ab896d3_migrate_old_labels.py Outdated Show resolved Hide resolved

jace commented Apr 26, 2019

View reviewed changes

migrations/versions/e2be4ab896d3_migrate_old_labels.py Outdated Show resolved Hide resolved

jace commented Apr 26, 2019

View reviewed changes

tests/conftest.py Outdated Show resolved Hide resolved

vidya-ram and others added 16 commits April 26, 2019 16:20

Change delete and archive to ajax post

5de04a7

fixed migration

8f18f14

linter fixes

0ffebb1

Fix the label widget

c37f4b7

Merge branch 'labels' of github.com:hasgeek/funnel into labels

19a9b46

deleting options before deleting main label

e8c8e78

removed labelseqform

e88416e

fixed syntax error

953bc35

fixed proposal edit page label form

b4e7de1

Add title_for_name

98954c7

fixed archived getter

344ac3b

Merge branch 'labels' of github.com:hasgeek/funnel into labels

063d773

Linter fixes

e0482fc

added test for label create, reorder and delete

e5fc767

reordering after label delete

30bb4be

Merge branch 'labels' of github.com:hasgeek/funnel into labels

08d497e

iambibhas marked this pull request as ready for review April 26, 2019 14:57

Bibhas and others added 3 commits April 26, 2019 21:49

added test for editing labels

4975b6f

Session type hasn't been used for a while

b71bc4e

Rename sublabel to option

8f9e45a

jace merged commit 5adf03c into master Apr 26, 2019

jace deleted the labels branch April 26, 2019 16:58

jace added a commit that referenced this pull request Jun 6, 2019

Remove proposal part labels (resolves #403)

b89e777

Also removes the obsolete session_type and technical_level columns that have been converted to labels as of #392.

jace mentioned this pull request Jun 6, 2019

Remove proposal part labels (resolves #403), sections and unused columns #436

Merged

jace mentioned this pull request Jul 2, 2019

Sponsor and SponsorLevel models #465

Closed

3 tasks

jace mentioned this pull request Jul 19, 2021

Labels need a new approach #1239

Open

vidya-ram pushed a commit that referenced this pull request Nov 23, 2021

Merge pull request #392 from hasgeek/labels

73ad164

Implement labels (resolves #313)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement labels (resolves #313) #392

Implement labels (resolves #313) #392

jace commented Apr 8, 2019 •

edited by vidya-ram

Loading

jace commented Apr 8, 2019

Implement labels (resolves #313) #392

Implement labels (resolves #313) #392

Conversation

jace commented Apr 8, 2019 • edited by vidya-ram Loading

jace commented Apr 8, 2019

jace commented Apr 8, 2019 •

edited by vidya-ram

Loading