Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsor model (implements #465) #1106

Merged
merged 8 commits into from
Apr 22, 2021
Merged

Sponsor model (implements #465) #1106

merged 8 commits into from
Apr 22, 2021

Conversation

jace
Copy link
Member

@jace jace commented Apr 22, 2021

Initial implementation of a SponsorMembership model, for #465. The model is stable, but UI is restricted to displaying existing sponsors. There is no UI yet for adding or removing sponsors, or changing their criteria (the label field and is_promoted flag). This functionality is pending.

The SponsorLevel model described in #465 is no longer considered necessary.

ImmutableMembershipMixin has been split into two baseclasses, for the User and Profile models respectively. A profile membership (where the profile is the member, such as in SponsorMembership) can be operated by anyone with an admin role on the profile.

@jace jace requested review from iambibhas and vidya-ram April 22, 2021 01:29
jace and others added 6 commits April 22, 2021 07:12
Since active memberships are the primary use case, don't use a prefix on active relationships, and use all_ prefix on the default relationship. This change is pending in other existing membership types.
@jace jace marked this pull request as ready for review April 22, 2021 09:30
@jace jace merged commit 823446a into master Apr 22, 2021
@jace jace deleted the sponsor-model branch April 22, 2021 09:38
@jace jace mentioned this pull request Apr 23, 2021
3 tasks
vidya-ram added a commit that referenced this pull request Nov 23, 2021
Co-authored-by: Vidya Ramakrishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants