-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search #438
Comments
First cut in #438. |
Should we also figure out how to track the searches and the popular resources that get consumed? |
Yes, but first cut can be from GA. Let's build custom analytics when we find something GA can't help with. |
Profile and project search were added a while ago, but the UI to access them is pending. We also need two other features:
|
Project and profile search is coming to the UI with #961. Label search is currently excluded because labels as a product feature are underdeveloped. The search feature is effectively complete as per this ticket's specification. A future ticket may want to introduce a DSL that extends the Postgres syntax, so that a query may filter on fields other than |
Closing this to continue feature tracking in #1066. |
Funnel needs the following three search endpoints, all of which accept a
q
parameter for the query and atype
parameter for the object type./search
/<profile>/search
/<profile>/<project>/search
Following the convention adopted in #321 (URL structure), the word
search
now joins the reserved names list.Search will apply to the following types:
Users are not included as there is nowhere to link to for users without profiles. Users will start appearing in search results once user profile pages are enabled (in #292).
The search page shows tabs for each type of result, with a pill containing the result count. Results are sorted by relevance (words appearing in titles take higher priority than content body, etc) and batched 20 at a time, with additional batches loaded automatically as the user scrolls down. There will be no batch navigation buttons.
The backend will accept a
start
parameter for the row number to begin a new batch at.The front-end will stop attempting to load batches once the originally promised number of results have been loaded.
The text was updated successfully, but these errors were encountered: