Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search #438

Closed
8 of 9 tasks
jace opened this issue Jun 7, 2019 · 6 comments
Closed
8 of 9 tasks

Add search #438

jace opened this issue Jun 7, 2019 · 6 comments
Assignees
Milestone

Comments

@jace
Copy link
Member

jace commented Jun 7, 2019

Funnel needs the following three search endpoints, all of which accept a q parameter for the query and a type parameter for the object type.

  1. /search
  2. /<profile>/search
  3. /<profile>/<project>/search

Following the convention adopted in #321 (URL structure), the word search now joins the reserved names list.

Search will apply to the following types:

  1. Profile (except when searching in a profile or project)
  2. Project (except when searching in a project)
  3. Proposal
  4. Session
  5. Comment
  6. Label

Users are not included as there is nowhere to link to for users without profiles. Users will start appearing in search results once user profile pages are enabled (in #292).

The search page shows tabs for each type of result, with a pill containing the result count. Results are sorted by relevance (words appearing in titles take higher priority than content body, etc) and batched 20 at a time, with additional batches loaded automatically as the user scrolls down. There will be no batch navigation buttons.

The backend will accept a start parameter for the row number to begin a new batch at.

The front-end will stop attempting to load batches once the originally promised number of results have been loaded.

@jace jace added this to the App frame milestone Jun 7, 2019
@jace
Copy link
Member Author

jace commented Jun 13, 2019

First cut in #438.

jace added a commit that referenced this issue Jun 17, 2019
@iambibhas
Copy link
Contributor

Should we also figure out how to track the searches and the popular resources that get consumed?

@jace
Copy link
Member Author

jace commented Feb 20, 2020

Yes, but first cut can be from GA. Let's build custom analytics when we find something GA can't help with.

@jace
Copy link
Member Author

jace commented Aug 20, 2020

Profile and project search were added a while ago, but the UI to access them is pending. We also need two other features:

  1. Autocomplete for search results. Don't wait for the user to submit.
  2. Consolidated results from across document types, with pills to let the user pick one/many (none selected implies all selected)

@jace
Copy link
Member Author

jace commented Mar 29, 2021

Project and profile search is coming to the UI with #961. Label search is currently excluded because labels as a product feature are underdeveloped. The search feature is effectively complete as per this ticket's specification. A future ticket may want to introduce a DSL that extends the Postgres syntax, so that a query may filter on fields other than search_vector.

@jace
Copy link
Member Author

jace commented Apr 8, 2021

Closing this to continue feature tracking in #1066.

@jace jace closed this as completed Apr 8, 2021
vidya-ram pushed a commit that referenced this issue Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants