Deprecate form_nonce (stage 1 of 2) #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
form_nonceis ineffective with JavaScript submits, where either the nonce is not regenerated, causing unrelated submits to be registered as dupes, or is regenerated just before submit, thereby causing dupe submits to have unique nonces which they shouldn't.Funnel has a new mechanism that is entirely server side and depends on request fingerprinting to detect dupes (hasgeek/funnel#2002). However, it will not work while random nonce values are part of the request, so
form_noncehas to be removed entirely.This PR only disables the validator. After downstream references to
form_nonceare removed, the field can also be removed.