Add version of baseframe-mui without select2. #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidya-ram
commented
Nov 4, 2019
| @@ -3559,7 +3559,6 @@ h4, h5, h6 { | |||
|
|
|||
| .content-wrapper { | |||
| position: relative; | |||
| z-index: 1; | |||
| padding-top: 50px; | |||
There was a problem hiding this comment.
Removed z-index of content wrapper div so that the select2 dropdown, which inside the this div can have an higher z-index than the fixed header
vidya-ram
commented
Nov 4, 2019
|
|
||
| .mui-select.select2 .mui-select__menu { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
For select2 enabled select fields, hide the default mui select dropdown.
vidya-ram
commented
Nov 4, 2019
| <div class="mui-select"> | ||
| {{ field | render_field_options(class="field-" + field.id + " " + widget_css_class, tabindex=tabindex, autofocus=autofocus, rows=rows)}} | ||
| <label>{{ field.label.text }}</label> | ||
| </div> | ||
| {%- elif field.type in ['SelectField', 'QuerySelectField', 'SelectMultipleField', 'QuerySelectMultipleField', 'UserSelectField', 'UserSelectMultiField', 'AutocompleteField', 'AutocompleteMultipleField', 'GeonameSelectField', 'GeonameSelectMultiField'] and field.widget.html_tag not in ['ul', 'ol'] %} | ||
| <div class="mui-select select2"> |
There was a problem hiding this comment.
To distinguish between select and select2 fields.
Incase of select2 enabled select, hide the default mui select dropdown.
jace
reviewed
Nov 4, 2019
| }); | ||
| } | ||
| //Remove the scroll lock class added by mui.js on opening select dropdown | ||
| $('select:not(.notselect)').on("select2:select", function(e) { |
There was a problem hiding this comment.
I think we can remove the :not approach when select2 is not enabled by default.
jace
reviewed
Nov 5, 2019
jace
approved these changes
Nov 6, 2019
|
|
|
Closing this since it's stale now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related changes in the apps
Funnel: hasgeek/funnel#513
Lastuser: hasgeek/lastuser#374
HGTV: hasgeek/hasgeek.tv#246