Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed a dead link in README.md #396

Merged
merged 1 commit into from
Jan 16, 2024
Merged

docs: fixed a dead link in README.md #396

merged 1 commit into from
Jan 16, 2024

Conversation

isaiahthedev
Copy link
Contributor

Description

The link that is supposed to take you to the CONTRIBUTING.md takes you to a non existent CONTRIBUTION.md. I also fixed the hash anchor to take you to the intended part of the page.

screenshots

oie_EyNVRnATByD5

The link that is supposed to take you to the CONTRIBUTING.md takes you to a non existent CONTRIBUTION.md. I also fixed the hash anchor to take you to the intended part of the page.
Copy link
Contributor

@shootermv shootermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! good catch!

@shootermv
Copy link
Contributor

one thing you need to correct - is a title of this PR: it should be prefixed with one of conventional prefixes (docs, fix, feat...)
this one for example - should be prefixed with docs

@isaiahthedev isaiahthedev changed the title 🔧 Fixed a Dead Link in README.md fix: fixed a dead link in README.md Jan 16, 2024
@isaiahthedev isaiahthedev changed the title fix: fixed a dead link in README.md docs: fixed a dead link in README.md Jan 16, 2024
@isaiahthedev
Copy link
Contributor Author

@shootermv Thank you, I finished the correction on the title 😄

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch! thanks 🥇

@NoamGaash NoamGaash enabled auto-merge (squash) January 16, 2024 09:21
@NoamGaash NoamGaash merged commit 8f43ef6 into hasadna:main Jan 16, 2024
17 of 18 checks passed
BinaHovav pushed a commit to BinaHovav/open-bus-map-search that referenced this pull request Jan 16, 2024
@isaiahthedev isaiahthedev deleted the patch-1 branch January 17, 2024 02:37
VSciFlight added a commit to VSciFlight/open-bus-map-search that referenced this pull request Jan 30, 2024


* 'main' of https://github.com/VSciFlight/open-bus-map-search: (94 commits)
  chore: lint css (hasadna#442)
  style: Ensure minimum width for ArrivalByTimeChart  (hasadna#433)
  fix: Remove unknown data (hasadna#438)
  chore: Revert "chore: add temporary route for the version release event (hasadna#382)" (hasadna#441)
  ci: upgrade linter (hasadna#439)
  fix: scrollbar color on dark mode (hasadna#431)
  fix: Fix for issue hasadna#428 unable to run project locally (hasadna#430)
  chore: Adding tnufa to dropdown in dashboard hasadna#423 (hasadna#429)
  chore(main): release 1.0.0 (hasadna#326)
  fix: make input labels visible at dark mode (hasadna#424)
  fix: make top input label visible at singleLine page (hasadna#420)
  chore: add i18n type safety (hasadna#419)
  feat: add home-page files and temp route (hasadna#403)
  feat: finish bug report form creation (hasadna#411)
  feat: Translation of the remaining untranslated text on the About page (hasadna#399)
  test: add SinglelinePage tests (hasadna#393)
  feat: made logo white on dark mode (hasadna#397)
  feat: date picker component show invalid dates warning (hasadna#398)
  chore: hide bug report form (hasadna#388)
  docs: fixed a dead link in README.md (hasadna#396)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants