Check image name length in preflight phase #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import OpenStack server by UUID - Import OpenStack server with upper case characters in its name The following improvements have been done: - Sanitize the configured `VirtualMachineName` field, e.g. convert upper case to lower case to make it RFC 1123 compliant. - Convert UUID to real name for OpenStack imports - Reduce waiting time to recheck if created VM is running from 5min to 2min - Rename variable `uuid` to `serverUUID` in the OpenStack client code to do not collide with the imported uuid module - Improve log messages - Fix typos - Add comments Related to: harvester/harvester#6500 Related to: harvester/harvester#6505 Signed-off-by: Volker Theile <[email protected]>
... to ensure the resulting name of the `VirtualMachineImage` will match the 63 characters limit. - Shorten the image display name from `<VMName>-<VMName>-<DiskIndex>` to the name of the disk `<VMName>-<DiskIndex>` to safe characters. This allows the import of VM with longer names. Related to: harvester/harvester#6463 Signed-off-by: Volker Theile <[email protected]>
Signed-off-by: Volker Theile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to ensure the resulting name of the
VirtualMachineImagewill match the 63 characters limit.<VMName>-<VMName>-<DiskIndex>to the name of the disk<VMName>-<DiskIndex>to safe characters. This allows the import of VM with longer names.Signed-off-by: Volker Theile [email protected]
Problem:
There's no way for users to know if VM import is failing due to exceeding naming character limit.
Solution:
Check if the expected image name is not exceeding the linit during the preflight phase.
Related Issue:
harvester/harvester#6463
Test plan:
ToDo...