Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump longhorn-manager and harvester version #93

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

brandboat
Copy link
Member

@brandboat brandboat commented Apr 12, 2024

related to harvester/harvester#5524

Description

  • Bump longhorn-manager to v1.6.0
  • Bump longhorn-manager to v1.3.0
  • Remove redundant replace rule

Test Plan

Setup: Create a Harvester cluster
Build terraform-harvester-provider

  1. execute make
  2. follow https://developer.hashicorp.com/terraform/cli/config/config-file#development-overrides-for-provider-developers to use terraform-harvester-provider from local build.
    provider_installation {
      dev_overrides {
        "harvester/harvester" = "/home/brandboat/Code/harvester/terraform-provider-harvester/bin"
      }
      direct {}
    }
    
  3. Add export TF_CLI_CONFIG_FILE=~/.terraformrc to .bashrc
  4. Test terraform create VM https://gist.github.com/brandboat/5a5279d9c13604d2465da3ce0b277743
  5. Run terraform apply

Check vm create successfully.

- Bump longhorn-manager to v1.6.0
- Bump longhorn-manager to v1.3.0
- Remove redundant replace rule
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@FrankYang0529 FrankYang0529 merged commit 980cb7f into harvester:master Apr 15, 2024
2 checks passed
@brandboat brandboat deleted the HARV-5524 branch April 15, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants