Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix go version with quote for release #87

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

FrankYang0529
Copy link
Member

Copy link
Contributor

@Yu-Jack Yu-Jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, interesting

@FrankYang0529 FrankYang0529 merged commit 0f6a4de into harvester:master Dec 22, 2023
@FrankYang0529 FrankYang0529 deleted the fix-ci branch December 22, 2023 04:32
@Yu-Jack
Copy link
Contributor

Yu-Jack commented Dec 22, 2023

Add context from https://github.com/actions/setup-go:

Note: Due to the peculiarities of YAML parsing, it is recommended to wrap the version in single quotation marks:

go-version: '1.20'

The recommendation is based on the YAML parser's behavior, which interprets non-wrapped values as numbers and, in the case of version 1.20, trims it down to 1.2, which may not be very obvious. Matching an unstable pre-release:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants