Allow -1 value for bond_miimon uplink bond option #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While not a valid option per the Kernel's documentation, Harvester uses -1 as a special value to preserve whatever the current value is. If -1 is not allowed and the option is simply omitted for the vlanconfig, the Terraform provider will always show a change of the state from -1 to "null" at every run.
huberpoa
approved these changes
Aug 22, 2023
mauriiciodias
approved these changes
Oct 25, 2023
FrankYang0529
approved these changes
Oct 26, 2023
Yu-Jack
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While not a valid option per the Kernel's documentation, Harvester uses -1 as a special value to preserve whatever the current value is. If -1 is not allowed and the option is simply omitted for the vlanconfig, the Terraform provider will always show a change of the state from -1 to "null" at every run.
The vlanconfig cannot be changed without stopping all the VM instances using it, which is why it would be useful to allow the special value that preserves the existing configuration.