-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add harvester_cloudinit_secret #76
feat: add harvester_cloudinit_secret #76
Conversation
8370598
to
78e5bb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to consider another test case:
- apply with user_data not empty
- change user_data to empty
- apply again
c3b9fdb
to
f9e73fd
Compare
Added test case 2. Thanks. |
Signed-off-by: Frank Yang <[email protected]>
f9e73fd
to
3e2e019
Compare
Any idea when this PR will be merged? |
Signed-off-by: futuretea <[email protected]>
9c3cfa6
to
8dcae1a
Compare
Signed-off-by: futuretea <[email protected]>
Signed-off-by: futuretea <[email protected]>
8dcae1a
to
0f442d5
Compare
Signed-off-by: futuretea <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the test cases are working fine, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and verified that the testing case works.
@bk201 please take a look when u are back only; merge the PR to process the validation first, thanks. |
Issue: harvester/harvester#2958
Test plan
Setup
Follow PR Test Env Setup
Case 1: Apply same terraform doesn't trigger change
main.tf
.terraform apply
. Terraform should addex1
andex2
secrets to the cluster.terraform apply
again. Nothing change.Case 2: Change content to empty will update the secret
main.tf
.terraform apply
. The content ofex1
andex2
secrets will be empty.terraform apply
again. Nothing change.