-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppot TPM #75
Suppot TPM #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested with command below
ubuntu@tf-test:~$ ls -l /dev/tpm*
crw-rw---- 1 tss root 10, 224 Mar 7 03:47 /dev/tpm0
crw-rw---- 1 tss tss 253, 65536 Mar 7 03:47 /dev/tpmrm0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add the tpm
config to the TF doc? thanks.
Signed-off-by: futuretea <[email protected]>
Signed-off-by: futuretea <[email protected]>
Signed-off-by: futuretea <[email protected]>
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also need to add the following note to the doc according to the upstream doc.
When customizing this VMI definition or creating your own, please keep in mind that the TPM device and the UEFI firmware with SecureBoot are both hard requirements of Windows 11. Not having them will cause the Windows 11 installation to fail early. Please also note that the SMM CPU feature is required for UEFI + SecureBoot. However, they can all be omitted in the case of a Windows 10 VM(I). Finally, we do not currently support TPM persistence, so any secret stored in the emulated TPM will be lost next time you boot the VMI. For example, do not enable BitLocker, as it will fail to find the encryption key next boot and you will have to manually enter the (55 characters!) recovery key each boot.
Related issues
harvester/harvester#2910
Test plan
Reviwer
Tester
Linux
ls -l /dev/tmp*
Windows
Note:
shortly after a prompt to “Press any key to boot from CD or DVD…”.
You have a few seconds to do so or the VM will fail to boot