Add the ability to provide reserved_memory annotation field in virtual machine

[TachunLin]

Related issues

harvester/harvester#3402

Test plan

• Setup test env by https://github.com/harvester/terraform-provider-harvester/wiki/PR-Test-Env-Setup for Reviwer

• Setup test env by https://github.com/harvester/terraform-provider-harvester/wiki/Use-the-master-head-docker-image-for-testing for Tester

• Create a test config file in the test container

  resource "harvester_image" "ubuntu20" {
    name      = "ubuntu20"
    namespace = "harvester-public"
  
    display_name = "ubuntu-20.04-server-cloudimg-amd64.img"
    source_type  = "download"
    url          = "http://cloud-images.ubuntu.com/releases/focal/release/ubuntu-20.04-server-cloudimg-amd64.img"
  }
  
  resource "harvester_virtualmachine" "ubuntu20" {
    name                 = "ubuntu20"
    namespace            = "default"
    restart_after_update = true
  
    description = "test ubuntu20 raw image"
    tags = {
      ssh-user = "ubuntu"
    }
  
    cpu    = 2
    memory = "2Gi"
  
    efi         = true
    secure_boot = true
  
    run_strategy    = "RerunOnFailure"
    hostname        = "ubuntu20"
    reserved_memory = "100Mi"
    machine_type    = "q35"
  
    network_interface {
      name           = "nic-1"
      wait_for_lease = true
    }
  
    disk {
      name       = "rootdisk"
      type       = "disk"
      size       = "10Gi"
      bus        = "virti
  
  

• Apply the resource

  terraform apply -auto-approve
  

• Check the reserved memory filed value can be added in VM config page

[TachunLin]

Tested the scenarios to change reserved memory to empty and delete can work as expected

Terraform will perform the following actions:

  # harvester_virtualmachine.ubuntu20 will be updated in-place
  ~ resource "harvester_virtualmachine" "ubuntu20" {
        id                   = "default/ubuntu20"
        name                 = "ubuntu20"
      - reserved_memory      = "300Mi" -> null
        tags                 = {
            "ssh-user" = "ubuntu"
        }
        # (13 unchanged attributes hidden)



        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
harvester_virtualmachine.ubuntu20: Modifying... [id=default/ubuntu20]
harvester_virtualmachine.ubuntu20: Still modifying... [id=default/ubuntu20, 10s elapsed]
harvester_virtualmachine.ubuntu20: Modifications complete after 13s [id=default/ubuntu20]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

Terraform will perform the following actions:

  # harvester_virtualmachine.ubuntu20 will be updated in-place
  ~ resource "harvester_virtualmachine" "ubuntu20" {
        id                   = "default/ubuntu20"
        name                 = "ubuntu20"
      - reserved_memory      = "300Mi" -> null
        tags                 = {
            "ssh-user" = "ubuntu"
        }
        # (13 unchanged attributes hidden)



        # (4 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
harvester_virtualmachine.ubuntu20: Modifying... [id=default/ubuntu20]
harvester_virtualmachine.ubuntu20: Still modifying... [id=default/ubuntu20, 10s elapsed]
harvester_virtualmachine.ubuntu20: Modifications complete after 19s [id=default/ubuntu20]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

[futuretea]

LGTM, Thanks!

[FrankYang0529]

LGTM. Thanks.

Test create with empty reserved_memory, create and update with non-empty reserved_memory.