Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support input devices #63

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Support input devices #63

merged 3 commits into from
Feb 10, 2023

Conversation

futuretea
Copy link
Contributor

@futuretea futuretea commented Dec 6, 2022

Signed-off-by: futuretea [email protected]

Related issues
harvester/harvester#3119

Depend PR
harvester/harvester#3247

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test the branch with rebase master. It works fine. LGTM.

@futuretea futuretea force-pushed the input branch 3 times, most recently from 33ff7df to 0503c46 Compare January 3, 2023 07:49
@futuretea
Copy link
Contributor Author

convert to Draft util PR harvester/harvester#3247 merged

@futuretea futuretea marked this pull request as draft February 3, 2023 04:15
@futuretea futuretea requested a review from guangbochen February 3, 2023 04:15
Signed-off-by: futuretea <[email protected]>
@futuretea futuretea marked this pull request as ready for review February 10, 2023 05:43
Copy link

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@guangbochen guangbochen merged commit 2ad18de into harvester:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants