Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass kubernetes context in the provider #55

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

vulkoingim
Copy link
Contributor

Add ability to pass kubernetes context in the provider.

GetNonInteractiveClientConfig (old) calls GetNonInteractiveClientConfigWithContext (new) internally with an empty context, so there's no change in behaviour there.

Renamed the constant FiledProviderKubeConfig as there was a typo before Filed... -> Field...

@futuretea
Copy link
Contributor

Thanks! @vulkoingim can you help to generate docs by CGO_ENABLED=0 go generate and commit the new docs?

@vulkoingim
Copy link
Contributor Author

Thanks! @vulkoingim can you help to generate docs by CGO_ENABLED=0 go generate and commit the new docs?

Ah yeah, missed that one :) I've generated the docs and pushed the changes.

Copy link
Contributor

@futuretea futuretea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@futuretea futuretea merged commit a096cea into harvester:master Oct 18, 2022
@futuretea futuretea mentioned this pull request Oct 18, 2022
@vulkoingim vulkoingim deleted the pass-kube-context branch October 19, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants