Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual machine resource: fix input devices #107

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

m-ildefons
Copy link
Contributor

Fix type conversion for input device blocks in virtual machine resource. Fix virtual machine resource deletion.

related-to: harvester/harvester#6647

Fix type conversion for input device blocks in virtual machine resource.
Fix virtual machine resource deletion.

related-to: harvester/harvester#6647

Signed-off-by: Moritz Röhrich <[email protected]>
@m-ildefons m-ildefons requested a review from Yu-Jack October 18, 2024 11:37
@m-ildefons m-ildefons self-assigned this Oct 18, 2024
@Yu-Jack Yu-Jack requested a review from FrankYang0529 October 20, 2024 15:10
Copy link
Contributor

@Yu-Jack Yu-Jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR. I can create a VM with following setting:

  input {
    name = "tablet"
    type = "tablet"
    bus  = "usb"
  }

@FrankYang0529 FrankYang0529 merged commit 72e76eb into harvester:master Nov 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants