Tests: Enable Acceptance Tests #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable acceptance tests and fix existing tests. 1) Enable running acceptance tests on `make test` command when the user places a kubeconfig file into the repository. This kubeconfig is necessary since the acceptance tests are checked against a real Harvester cluster. If the kubeconfig file is missing, only unit tests are run, which doesn't require a Harvester cluster. 2) Fix existing tests. Some existing acceptance tests where using invalid terraform resources. These are fixed 3) Fix volume and network resource providers. Running acceptance tests revealed bugs in the volume and network resource providers. Both were using an incorrect method to determine if a resource had been deleted in Harvester. The bug was that the resource providers were waiting for a deletion event, despite the fact that the respective controllers don't emit such an event. The fix is to observe the resource through a periodic read. 4) Fix propagating the cluster network name of a network resource into the terraform state. The terraform state needs to keep track of this property to determine if the resource definition has changed. Otherwise the resource will always count as modified, which is in some cases wrong. This bug was also revealed by the acceptance tests. Signed-off-by: Moritz Röhrich <[email protected]>
FrankYang0529
approved these changes
Sep 18, 2024
bk201
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable acceptance tests and fix existing tests and providers
make testcommand when the userplaces a kubeconfig file into the repository. This kubeconfig is
necessary since the acceptance tests are checked against a real
Harvester cluster. If the kubeconfig file is missing, only unit tests
are run, which doesn't require a Harvester cluster.
invalid terraform resources. These are fixed
revealed bugs in the volume and network resource providers. Both were
using an incorrect method to determine if a resource had been deleted
in Harvester. The bug was that the resource providers were waiting
for a deletion event, despite the fact that the respective
controllers don't emit such an event. The fix is to observe the
resource through a periodic read.
the terraform state. The terraform state needs to keep track of this
property to determine if the resource definition has changed.
Otherwise the resource will always count as modified, which is in
some cases wrong. This bug was also revealed by the acceptance tests.
Related-To: harvester/harvester#6415