Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move image build from drone CI to github action #100

Merged
merged 2 commits into from
May 30, 2024

Conversation

mingshuoqiu
Copy link
Contributor

Problem:
replace Drone CI by github action

Solution:
Move the image building to github action

Related Issue:
harvester/harvester#5327

Test plan:
None

@mingshuoqiu mingshuoqiu requested review from bk201 and starbops May 20, 2024 05:08
@bk201 bk201 requested review from Yu-Jack and removed request for starbops May 29, 2024 09:04
Copy link
Contributor

@Yu-Jack Yu-Jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

.github/workflows/main.yml Outdated Show resolved Hide resolved
mingshuoqiu and others added 2 commits May 30, 2024 18:25
dist is no longer required

Signed-off-by: Chris Chiu <[email protected]>
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mingshuoqiu mingshuoqiu merged commit e23174e into harvester:master May 30, 2024
4 checks passed
@mingshuoqiu mingshuoqiu deleted the issue_5327 branch May 30, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants