ignore specified update in NAD webhook

- For nad validating webhook, ignore the update if the config and route annotation are not being updated.
- For nad mutating webhook, ignore the update if the config is not being updated.

pkg/controller/manager/clusternetwork/controller.go

@@ -132,7 +132,7 @@ func (h Handler) deleteLinkMonitor(name string) error {
 func (h Handler) setNadReadyLabel(cn *networkv1.ClusterNetwork) error {
 	isReady := utils.ValueFalse
 	// Set all net-attach-defs under the cluster network to be deleted as unready
-	if cn.DeletionTimestamp != nil && networkv1.Ready.IsTrue(cn.Status) {
+	if cn.DeletionTimestamp == nil && networkv1.Ready.IsTrue(cn.Status) {
 		isReady = utils.ValueTrue
 	}
 

pkg/webhook/nad/mutator.go

@@ -37,7 +37,7 @@ func (m *Mutator) Update(_ *types.Request, oldObj, newObj runtime.Object) (types
 	if newNad.DeletionTimestamp != nil {
 		return nil, nil
 	}
-
+	// ignore the update if the config is not being updated
 	if oldNad.Spec.Config == newNad.Spec.Config {
 		return nil, nil
 	}
@@ -120,6 +120,7 @@ func (m *Mutator) ensureLabels(nad *cniv1.NetworkAttachmentDefinition, oldConf,
 		}}, nil
 }
 
+// If the vlan or bridge name is changed, we need to tag the route annotation outdated
 func tagRouteOutdated(nad *cniv1.NetworkAttachmentDefinition, oldConf, newConf *utils.NetConf) (types.Patch, error) {
 	if oldConf.BrName == newConf.BrName && oldConf.Vlan == newConf.Vlan {
 		return nil, nil

pkg/webhook/nad/validator.go

@@ -48,10 +48,17 @@ func (v *Validator) Create(_ *types.Request, newObj runtime.Object) error {
 
 func (v *Validator) Update(_ *types.Request, oldObj, newObj runtime.Object) error {
 	newNad := newObj.(*cniv1.NetworkAttachmentDefinition)
+	oldNad := oldObj.(*cniv1.NetworkAttachmentDefinition)
 
+	// ignore the update if the resource is being deleted
 	if newNad.DeletionTimestamp != nil {
 		return nil
 	}
+	// ignore the update if the config and route are not being updated
+	if newNad.Spec.Config == oldNad.Spec.Config &&
+		newNad.Annotations[utils.KeyNetworkRoute] == oldNad.Annotations[utils.KeyNetworkRoute] {
+		return nil
+	}
 
 	if err := v.checkNadConfig(newNad.Spec.Config); err != nil {
 		return fmt.Errorf(updateErr, newNad.Namespace, newNad.Name, err)