Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set VipMode value in static mode (backport #930) #935

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 21, 2025

Problem:

When using static mode VIP, the installer is blocked.

Solution:

Set proper VipMode value.

Related Issue:
harvester/harvester#7362

Test plan:

Install Harvester in any mode, it should success.


This is an automatic backport of pull request #930 done by Mergify.

* Set VipMode value in static mode

Signed-off-by: Jian Wang <[email protected]>

* Use precise message for VipMode

Signed-off-by: Jian Wang <[email protected]>

---------

Signed-off-by: Jian Wang <[email protected]>
(cherry picked from commit 9ae474d)

# Conflicts:
#	pkg/console/install_panels.go
Copy link
Author

mergify bot commented Jan 21, 2025

Cherry-pick of 9ae474d has failed:

On branch mergify/bp/v1.4/pr-930
Your branch is up to date with 'origin/v1.4'.

You are currently cherry-picking commit 9ae474d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   pkg/console/validator.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pkg/console/install_panels.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jan 21, 2025
@w13915984028
Copy link
Member

Not required for v1.4 branch.

cc @tserong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant