Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add EnableGoCoverDir #591

Merged
merged 1 commit into from
Nov 27, 2023
Merged

feat: add EnableGoCoverDir #591

merged 1 commit into from
Nov 27, 2023

Conversation

FrankYang0529
Copy link
Member

@FrankYang0529 FrankYang0529 commented Nov 14, 2023 •
edited
Loading

Solution:
Add EnableGoCoverDir to config.

Related Issue:
harvester/harvester#2666

Test plan:

  1. Add following to https://github.com/harvester/ipxe-examples/blob/main/vagrant-pxe-harvester/ansible/roles/harvester/templates/config-create.yaml.j2.
install:
  # ...
  harvester:
    enableGoCoverDir: true
  1. Run ./setup_harvester.sh with master-head images.
  2. After the cluster is ready, check whether there is /go-cover-dir folder in harvester pod.

Additional context:
Wait for harvester/harvester#4722.

bk201
bk201 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bk201 bk201 requested a review from ibrokethecloud November 22, 2023 14:45
ibrokethecloud
ibrokethecloud approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks.

@FrankYang0529 FrankYang0529 merged commit d29437e into harvester:master Nov 27, 2023
4 checks passed
@FrankYang0529 FrankYang0529 deleted the HARV-2666 branch November 27, 2023 03:35
@FrankYang0529
Copy link
Member Author

@Mergifyio backport v1.2 v1.1

@mergify Mergify
Copy link

mergify bot commented Nov 27, 2023 •
edited
Loading

backport v1.2 v1.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 27, 2023
@FrankYang0529 @mergify
feat: add EnableGoCoverDir (#591)
3549d1b 
Signed-off-by: PoAn Yang <[email protected]>
(cherry picked from commit d29437e)
@mergify mergify bot mentioned this pull request Nov 27, 2023
Merged
mergify bot pushed a commit that referenced this pull request Nov 27, 2023
@FrankYang0529 @mergify
feat: add EnableGoCoverDir (#591)
6867142 
Signed-off-by: PoAn Yang <[email protected]>
(cherry picked from commit d29437e)

# Conflicts:
#	pkg/config/config.go
#	pkg/config/templates/rancherd-10-harvester.yaml
@mergify mergify bot mentioned this pull request Nov 27, 2023
Merged
FrankYang0529 added a commit that referenced this pull request Nov 27, 2023
@FrankYang0529
feat: add EnableGoCoverDir (#591)
05bce5c 
Signed-off-by: PoAn Yang <[email protected]>
(cherry picked from commit d29437e)
Vicente-Cheng pushed a commit that referenced this pull request Nov 29, 2023
@FrankYang0529 @Vicente-Cheng
feat: add EnableGoCoverDir (#591)
89a46d3 
Signed-off-by: PoAn Yang <[email protected]>
(cherry picked from commit d29437e)
Vicente-Cheng pushed a commit that referenced this pull request Nov 29, 2023
@FrankYang0529 @Vicente-Cheng
feat: add EnableGoCoverDir (#591)
280eac1 
Signed-off-by: PoAn Yang <[email protected]>
(cherry picked from commit d29437e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrokethecloud ibrokethecloud ibrokethecloud approved these changes

@bk201 bk201 bk201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYang0529 @bk201 @ibrokethecloud