chore: fix linter issues

Related issue: harvester/harvester#7336 Signed-off-by: Tim Serong <[email protected]>
harvester · Jan 10, 2025 · c78f37a · c78f37a
1 parent ac36f1f
commit c78f37a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -32,10 +32,10 @@ const (
 )
 
 const (
-	SingleDiskMinSizeGiB   = 250
-	MultipleDiskMinSizeGiB = 180
-	HardMinDataDiskSizeGiB = 50
-	MaxPods                = 200
+	SingleDiskMinSizeGiB   uint64 = 250
+	MultipleDiskMinSizeGiB uint64 = 180
+	HardMinDataDiskSizeGiB uint64 = 50
+	MaxPods                       = 200
 )
 
 // refer: https://github.com/harvester/harvester/blob/master/pkg/settings/settings.go

diff --git a/pkg/console/spinner.go b/pkg/console/spinner.go
@@ -79,7 +79,7 @@ func (s *Spinner) Stop(err bool, message string) {
 	<-s.stopped
 }
 
-func (s *Spinner) writePanel(message string, clear bool, fgColor gocui.Attribute) {
+func (s *Spinner) writePanel(message string, clearView bool, fgColor gocui.Attribute) {
 	// g.Update spawns a goroutine to notify gocui to update.
 	// wait until cui consumes the notification to make sure any remaining
 	// writePanel calls don't go first
@@ -100,7 +100,7 @@ func (s *Spinner) writePanel(message string, clear bool, fgColor gocui.Attribute
 		if s.focus {
 			g.SetCurrentView(s.panel)
 		}
-		if clear {
+		if clearView {
 			v.Clear()
 		}
 		v.FgColor = fgColor

diff --git a/pkg/console/util.go b/pkg/console/util.go
@@ -451,7 +451,7 @@ func saveElementalConfig(obj interface{}) (string, string, error) {
 	}
 
 	elementalConfigFile := filepath.Join(ElementalConfigDir, ElementalConfigFile)
-	err = ioutil.WriteFile(elementalConfigFile, bytes, os.ModePerm)
+	err = ioutil.WriteFile(elementalConfigFile, bytes, 0600)
 	if err != nil {
 		return "", "", err
 	}
@@ -703,7 +703,7 @@ func validateDiskSize(devPath string, single bool) error {
 	if !single {
 		limit = config.MultipleDiskMinSizeGiB
 	}
-	if util.ByteToGi(diskSizeBytes) < uint64(limit) {
+	if util.ByteToGi(diskSizeBytes) < limit {
 		return fmt.Errorf("Installation disk size is too small. Minimum %dGi is required", limit)
 	}
 
@@ -1047,7 +1047,7 @@ const (
 // identifyUniqueDisks parses the json output of lsblk and identifies
 // unique disks by comparing their serial number info and wwn details
 func identifyUniqueDisks(output []byte) ([]string, error) {
-	var returnDisks []string
+	returnDisks := []string{}
 	disks := &BlockDevices{}
 	err := json.Unmarshal(output, disks)
 	if err != nil {

diff --git a/pkg/util/common.go b/pkg/util/common.go
@@ -31,12 +31,12 @@ func DupStrings(src []string) []string {
 	return s
 }
 
-func ByteToGi(byte uint64) uint64 {
-	return byte >> 30
+func ByteToGi(b uint64) uint64 {
+	return b >> 30
 }
 
-func ByteToMi(byte uint64) uint64 {
-	return byte >> 20
+func ByteToMi(b uint64) uint64 {
+	return b >> 20
 }
 
 func GiToByte(gi uint64) uint64 {