Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup rancher and harvester in air-gapped environment #137

Conversation

FrankYang0529
Copy link
Member

No description provided.

@FrankYang0529 FrankYang0529 force-pushed the add-air-gap-setup-without-proxy branch from 251cca4 to 4d0d8bf Compare April 8, 2022 10:19
@FrankYang0529 FrankYang0529 force-pushed the add-air-gap-setup-without-proxy branch from 4d0d8bf to c736499 Compare May 3, 2022 05:45
@FrankYang0529 FrankYang0529 force-pushed the add-air-gap-setup-without-proxy branch from c736499 to 320d6ab Compare May 3, 2022 06:07
Copy link

@TachunLin TachunLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Appreciate for the update

@guangbochen
Copy link
Contributor

The content looks good to me, but in regards to the Rancher air-gap setup, I would prefer to link it to a particular Rancher doc page as Rancher should constantly maintain and update it, but we can always add some important notes on this section.

@guangbochen guangbochen removed their request for review October 19, 2022 01:40
@LucasSaintarbor LucasSaintarbor self-requested a review March 2, 2023 21:44
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small changes. LGTM 👍 @TachunLin is it okay to merge this? I will create a different PR to add this to https://github.com/harvester/docs/blob/main/versioned_docs/version-v1.1/airgap.md

docs/airgap.md Outdated Show resolved Hide resolved
docs/airgap.md Outdated Show resolved Hide resolved
docs/airgap.md Outdated Show resolved Hide resolved
docs/airgap.md Outdated Show resolved Hide resolved
docs/airgap.md Outdated Show resolved Hide resolved
docs/airgap.md Outdated Show resolved Hide resolved
docs/airgap.md Outdated Show resolved Hide resolved
docs/airgap.md Outdated Show resolved Hide resolved
docs/airgap.md Outdated Show resolved Hide resolved
docs/airgap.md Outdated Show resolved Hide resolved
@TachunLin
Copy link

TachunLin commented Mar 17, 2023

Hi @LucasSaintarbor, thanks for the check.
It looks good to me. Please feel free to merge

if you are going to create a separate PR for adding the changes.
A suggested update is we can add indent to the code block to let the numbering bullet work better.
image

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for harvester-preview failed.

Name Link
🔨 Latest commit 6f87493
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/64bee891c2f1aa0008bcab36

@LucasSaintarbor
Copy link
Contributor

Hi @FrankYang0529, sorry for being late to this. Since this PR is older, is was created using the old site generator Material for MkDocs and not Docusaurus 2. I am going to create a new PR from my fork https://github.com/LucasSaintarbor/harvester-docs/tree/main with the same changes, and then I'll follow up here to close this PR.

@FrankYang0529
Copy link
Member Author

Hi @FrankYang0529, sorry for being late to this. Since this PR is older, is was created using the old site generator Material for MkDocs and not Docusaurus 2. I am going to create a new PR from my fork https://github.com/LucasSaintarbor/harvester-docs/tree/main with the same changes, and then I'll follow up here to close this PR.

Hi @LucasSaintarbor, thanks for the help. Sounds good to me. Feel free to close this PR after you submit a new one. 👍

@LucasSaintarbor
Copy link
Contributor

Per #137 (comment), opened new PR #371 - Updated airgap.md with steps to setup rancher and harvester in air-gapped env #371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants