-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setup rancher and harvester in air-gapped environment #137
Add setup rancher and harvester in air-gapped environment #137
Conversation
251cca4
to
4d0d8bf
Compare
4d0d8bf
to
c736499
Compare
Signed-off-by: Frank Yang <[email protected]>
c736499
to
320d6ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Appreciate for the update
The content looks good to me, but in regards to the Rancher air-gap setup, I would prefer to link it to a particular Rancher doc page as Rancher should constantly maintain and update it, but we can always add some important notes on this section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some small changes. LGTM 👍 @TachunLin is it okay to merge this? I will create a different PR to add this to https://github.com/harvester/docs/blob/main/versioned_docs/version-v1.1/airgap.md
Hi @LucasSaintarbor, thanks for the check. if you are going to create a separate PR for adding the changes. |
❌ Deploy Preview for harvester-preview failed.
|
Hi @FrankYang0529, sorry for being late to this. Since this PR is older, is was created using the old site generator Material for MkDocs and not Docusaurus 2. I am going to create a new PR from my fork https://github.com/LucasSaintarbor/harvester-docs/tree/main with the same changes, and then I'll follow up here to close this PR. |
Hi @LucasSaintarbor, thanks for the help. Sounds good to me. Feel free to close this PR after you submit a new one. 👍 |
Per #137 (comment), opened new PR #371 - Updated airgap.md with steps to setup rancher and harvester in air-gapped env #371 |
No description provided.