Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harvester-node-manager: update RBAC for eventing #206

Merged
merged 1 commit into from
Jan 24, 2024
Merged

harvester-node-manager: update RBAC for eventing #206

merged 1 commit into from
Jan 24, 2024

Conversation

connorkuehl
Copy link
Contributor

@connorkuehl connorkuehl commented Jan 18, 2024

A new controller in harvester-node-manager emits events whenever it modifies one of the files under its management. In order to do so successfully, it needs the capability added to the node-manager chart RBAC.

A new controller in harvester-node-manager emits events whenever it
modifies one of the files under its management. In order to do so
successfully, it needs the capability added to the node-manager chart
RBAC.

Signed-off-by: Connor Kuehl <[email protected]>
Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update! lgtm

Copy link

@markhillgit markhillgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok! thank you.

@markhillgit markhillgit merged commit 7d74c41 into harvester:master Jan 24, 2024
2 checks passed
@connorkuehl connorkuehl deleted the events branch January 24, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants