add quickswap gamma pools #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryptJS13
reviewed
Feb 20, 2023
data/mainnet/pools.js
Outdated
| rewardAPY: [], | ||
| rewardAPR: null, | ||
| rewardTokens: [addresses.MATIC.miFARM], | ||
| rewardTokenSymbols: ['miFARM', 'WMATIC', 'dQUICK'], |
There was a problem hiding this comment.
Only miFARM, same comment for the other pools
data/mainnet/pools.js
Outdated
| <ol class="numeric-list"> | ||
| <li> | ||
| Go to | ||
| <a target="_blank" rel="noopener noreferrer" href="https://quickswap.exchange/#/pools?currency0=${addresses.MATIC.WMATIC}¤cy1=${addresses.MATIC.pWETH}"> |
There was a problem hiding this comment.
Wrong link, we need a link to quickswap.gamma.xyz for the correct pool. Same for the other pools
| chain: CHAINS_ID.MATIC_MAINNET, | ||
| logoUrl: './icons/wmatic_eth.png', | ||
| apyIconUrls: ['./icons/quick.png', './icons/wmatic.png'], | ||
| apyTokenSymbols: ['dQUICK', 'WMATIC'], |
There was a problem hiding this comment.
Not all the pools earn wMATIC, please check and only add for the pools that get wMATIC
There was a problem hiding this comment.
https://quickswap.gamma.xyz/dashboard
Via this link, all pools are getting dQuick and wMatic.
| let totalSupply = get(response, `data.${poolAddress.toLowerCase()}.totalSupply`, 0) | ||
| totalSupply = new BigNumber(totalSupply).dividedBy(new BigNumber(10).pow(18)) | ||
| if (totalSupply && totalSupply > 0) { | ||
| price = parseFloat(tvlUSD) / totalSupply.toFixed(2, 1) |
There was a problem hiding this comment.
Probably better to not round the totalSupply number, can just use toFixed()
CryptJS13
reviewed
Feb 20, 2023
| @@ -12,7 +12,7 @@ const getPrice = async poolAddress => { | |||
| let totalSupply = get(response, `data.${poolAddress.toLowerCase()}.totalSupply`, 0) | |||
| totalSupply = new BigNumber(totalSupply).dividedBy(new BigNumber(10).pow(18)) | |||
| if (totalSupply && totalSupply > 0) { | |||
| price = parseFloat(tvlUSD) / totalSupply.toFixed(2, 1) | |||
| price = parseFloat(tvlUSD) / totalSupply.toFixed(2) | |||
There was a problem hiding this comment.
This is still rounding to 2 decimals, which is not necessary.
CryptJS13
approved these changes
Feb 20, 2023
CryptJS13
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.