Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unique_keys_by_set.yml #57

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Update unique_keys_by_set.yml #57

merged 1 commit into from
Jan 25, 2023

Conversation

dl-maura
Copy link
Contributor

This allows VV to use the Ming Alias since it uses a special id field

To test:

Point your local to this branch of the oai gem and rebuild as necessary. You should then be able to do a harvest using the following fields:

Set Spec: ming
Solr Query Filter: painting.format:"Ink on paper"

Before Set Spec: ming would fail but now it will harvest.

@phil-plencner-hl
Copy link
Contributor

@dl-maura
Copy link
Contributor Author

@phil-plencner-hl Yes! And the job shouldn't fail which was happening before (it will fail on qa)

Copy link
Contributor

@phil-plencner-hl phil-plencner-hl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to successfully harvest Ming. Approved.

@phil-plencner-hl phil-plencner-hl merged commit f565c36 into main Jan 25, 2023
@phil-plencner-hl phil-plencner-hl deleted the fix-ming-alias branch January 25, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants