Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow records with multiple thumbnails to import #41

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Allow records with multiple thumbnails to import #41

merged 2 commits into from
Oct 11, 2022

Conversation

bkiahstroud
Copy link
Contributor

Summary

Only perform HTTP request if there is only one uri.

Some records currently get parsed with multiple thumbnail/full image urls concatenated together. This was throwing errors and preventing the records from coming in at all. For parity with the old site, we now allow these records to be imported with broken images so that at least the record is in the system.

Screenshots

Curation - Dashboard jbsd - Harvard Curiosity 2022-10-11 at 12 41 54 PM

Echinoderm (Tortugas, Florida, 1858) - jbsd - Harvard Curiosity 2022-10-11 at 12 42 53 PM

Testing Instructions

  1. Login as an admin
  2. Harvest the jbsd set using the jbsd.yml mapping file
  3. When the harvest completes, search for this URN: ARC_237-032
  4. The thumbnail won't show up in the search results. This is expected
  5. Click on the item
  6. The Mirador viewer will display an error. This is expected
  7. The record and its metadata existing at all are proof that this is working

only perform HTTP request if there is only one uri
b39af50 
Some records currently get parsed with multiple thumbnail/full image urls concatenated together. This was throwing errors and preventing the records from coming in at all.
For parity with the old site, we now allow these records to be imported with broken images so that at least the record is in the system.
@bkiahstroud bkiahstroud requested a review from dl-maura October 11, 2022 19:51
phil-plencner-hl
phil-plencner-hl approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@phil-plencner-hl phil-plencner-hl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described for me!

@phil-plencner-hl phil-plencner-hl merged commit 39075bc into main Oct 11, 2022
@phil-plencner-hl phil-plencner-hl deleted the allow-records-with-multiple-thumbnails-to-import branch October 11, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-plencner-hl phil-plencner-hl phil-plencner-hl approved these changes

@dl-maura dl-maura Awaiting requested review from dl-maura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkiahstroud @phil-plencner-hl