Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture more errors in LoadUrnsJob to avoid "false positive" harvest reporting #40

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

bkiahstroud
Copy link
Contributor

@bkiahstroud bkiahstroud commented Oct 10, 2022

Ref https://github.com/harvard-lts/CURIOSity/issues/215

Summary

There was a small section in the harvest logic where errors were not being captured and handled. If an error was thrown somewhere in this section, it would cause the initial PerformHarvestsJob to fail. This failed job would then retry itself several times, failing silently all the way. And because the errors weren't being captured, no information would be visible to the user looking in modal in the "Recent indexing activity" section of the Exhibit Dashboard.

This PR includes two key changes:

  1. Capture the error

Capturing the error prevents the job from retrying itself over and over. This frees up the background working to work on other processes.

  1. Handle the error

Handling the error means bubbling it up to the user, specifically in the harvest status modal. This lets the user know 1) something went wrong and 2) possibly what they can do about it.

Screenshots

Before

Curation - Dashboard demo - Harvard Curiosity 2022-10-10 at 11 41 08 AM

After

Curation - Dashboard demo - Harvard Curiosity 2022-10-10 at 11 44 05 AM

Testing Instructions

Please refer to the ticket.

Copy link
Contributor

@phil-plencner-hl phil-plencner-hl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as described.

I also updated the version of the gem to 3.0.0.pre.beta.10 so that we can deploy this to CURIOSity.

Approved.

@phil-plencner-hl phil-plencner-hl merged commit e4081cb into main Oct 11, 2022
@phil-plencner-hl phil-plencner-hl deleted the improve-error-tracking-in-load-urns-job branch October 11, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants