i137 Fix broken thumbnails pt. 2 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jeremyf
reviewed
Aug 17, 2022
| #Append /info.json to end | ||
| uri = uri.gsub('/full/150,/0/default.jpg', '') | ||
| # Append iiif format (thumbnail version) | ||
| uri = uri.gsub(/\/full\/\d*,\d*\/0\/default.jpg/, '') |
There was a problem hiding this comment.
Reading notes: Instead of assuming the thumbnail of 150 this now allows for thumbnails of varied size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/harvard-lts/CURIOSity/issues/137
Summary
This line wasn't accounting for all the possible incoming values and thus was only fixing some of the broken thumbnails:
Changes: