i133 Ensure all data updates if an item has already been harvested #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkiahstroud
changed the title
|
Converting to draft: I discovered this introduces a bug where only a small set of data is harvested on the first harvest |
added 3 commits
August 15, 2022 10:41
This fixes a bug where, the first time a set is harvested, none of the resource metadata gets indexed in solr. Harvesting the same set again would populate the data in solr. My best guess as to what was happening is that #find_or_create_by was creating an empty sidecar doc, which then for some reason wasn't getting updated when calling #save_and_index on its resource. Instead, I've opted to set up all the data before committing anything to the db/solr. Now, the first harvest of a set brings in the metadata as expected.
See this commit for the resolution & explanation |
jeremyf
approved these changes
Aug 16, 2022
Merged
dl-maura
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/harvard-lts/CURIOSity/issues/133
find_or_create_bywon't execute itsdoblock if a record is found. This was skipping the update of data for existing records. Additionally, newly added fields were not persisting on records that already existed. This PR fixes both issues