Replace print statements with logging #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- defaults to only console logging - defaults to WARNING level - configurable with: `export APP_LOG_LEVEL=[INFO|DEBUG]`
* linter for box reader after logging * comment out diff cover remove socket * skip processing of files where n value is not 1 * tests with 65% cvg * add in github actions install of diff cover globally * update paths for diff cover * test diff cover install and check path * uncomment diff cover test * uncomment diff cover test 2 * new coverage test * full test coverage * flake8 passes all files * check flake8 version * mod flake8 command for 120 line length * add additional test coverage, stops early if not 85
kimpham54
added a commit
that referenced
this pull request
Nov 15, 2024
* Replace print statements with logging - defaults to only console logging - defaults to WARNING level - configurable with: `export APP_LOG_LEVEL=[INFO|DEBUG]` * Merge awoods-logging into logging (#3) * linter for box reader after logging * comment out diff cover remove socket * skip processing of files where n value is not 1 * tests with 65% cvg * add in github actions install of diff cover globally * update paths for diff cover * test diff cover install and check path * uncomment diff cover test * uncomment diff cover test 2 * new coverage test * full test coverage * flake8 passes all files * check flake8 version * mod flake8 command for 120 line length * add additional test coverage, stops early if not 85 --------- Co-authored-by: kim pham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export APP_LOG_LEVEL=[INFO|DEBUG]