Tweak logging #3423
Merged
Tweak logging #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccacremona
requested review from
matteocargnelutti
and removed request for
a team
bensteinberg
approved these changes
Oct 31, 2023
|
🏄 ! |
matteocargnelutti
approved these changes
Oct 31, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3423 +/- ##
===========================================
- Coverage 68.79% 68.78% -0.02%
===========================================
Files 53 53
Lines 7317 7316 -1
===========================================
- Hits 5034 5032 -2
- Misses 2283 2284 +1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small PR to tweak our logging of captures made with the Scoop API.
We now store the Scoop job id in a dedicated database field, so that it is available even if the job never advanced beyond this loop (one variety of error we have been debugging).
We log the Scoop job id and status while in the loop, to make it easier to match up Perma logs and Scoop API logs, when something goes wrong.