Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak to "no PageInfo" check #3422

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

rebeccacremona
Copy link
Contributor

#3421 was over broad: we expect pageInfo to be present but empty whenever the capture target is retrieved out-of-browser (like a direct link to a PDF, for example).

This PR just looks for the presence of the key.

It also make some tweaks to the Django admin for our convenience.

@rebeccacremona rebeccacremona requested a review from a team as a code owner October 30, 2023 19:03
@rebeccacremona rebeccacremona requested review from kilbergr and removed request for a team October 30, 2023 19:03
@bensteinberg bensteinberg removed the request for review from kilbergr October 30, 2023 19:05
@codecov
Copy link

codecov bot commented Oct 30, 2023

We're currently processing your upload. This comment will be updated when the results are available.

@rebeccacremona rebeccacremona merged commit d8def7c into harvard-lil:develop Oct 30, 2023
2 checks passed
@rebeccacremona rebeccacremona deleted the tweak-no-pageinfo branch October 31, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants